[release/5.0.1xx] Add arcade-powered source-build strict coherent parent dependencies #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
commented
Sep 1, 2020
| @@ -124,7 +124,7 @@ | |||
| <PropertyGroup> | |||
| <VersionToolsVersion>2.2.0-beta.19072.10</VersionToolsVersion> | |||
| <DotnetDebToolVersion>2.0.0</DotnetDebToolVersion> | |||
| <MicrosoftNETTestSdkVersion>15.8.0</MicrosoftNETTestSdkVersion> | |||
| <MicrosoftNETTestSdkVersion>16.8.0-release-20200828-02</MicrosoftNETTestSdkVersion> | |||
There was a problem hiding this comment.
The last time this was touched was the migration to Arcade: #140. It's apparently test-only, which could explain why it's behind the coherent product:
Lines 123 to 127 in b303c1b
It's not used in dotnet/installer. I think it's used to override this Arcade default: https://github.com/dotnet/arcade/blob/e11b8486ad155fab13e788a268755c0ca60d3609/src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props#L81
If it's necessary to use an old version, we'll have to figure out how to move this prop out of the file (or depend on a different nupkg out of vstest, but that seems more fragile).
mmitche
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dependencies for repos that source-build builds, but aren't in this repo yet. We're going to rely on dotnet/installer to know what sources belong in the arcade-powered source-build tarball.
dotnet/source-build#1563
https://github.com/dotnet/source-build/tree/release/3.1/Documentation/planning/arcade-powered-source-build
These dependencies won't be used right this second, but I think we should check them in anyway: